-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update climacommon to 2024_12_16 #3369
base: main
Are you sure you want to change the base?
Conversation
5bcb62f
to
9446cc7
Compare
7f53669
to
078c0b8
Compare
Among the GHA tests, it looks like the windows job gets the farthest, reaching (but not completing) |
On buildkite, it looks like some jobs are getting precompiled twice, ah this is likely due to using a fixed old version of atmos. Developing atmos in the perf env should fix this, I think. |
We can increase the ref counter to fix the reproducibility tests, could someone review the physics changes? |
Finally, the MPI job looks like it may be running out of memory, could we increase the mem request for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall updating to julia 1.11 is fine with me, but it looks like we need to address some things that need fixed.
f12ee9e
to
fa8cdd8
Compare
I am finding that ClimaCore 0.14.12 is fine with Julia 1.10, but we need 0.14.19 for Julia 1.11 (https://github.com/CliMA/ClimaAtmos.jl/actions/runs/12694181365/job/35383420600). Unfortunately, I don't see any easy way to specify this constraint, so maybe the safest is just bumping the minimum to 0.14.19 |
fa8cdd8
to
b661730
Compare
That makes sense. We kind of got bit by JuliaLang/julia#56295. The main branch is fine, but the high-level dispatch that effectively fixed this issue must have been merged in 0.14.19. I don't know what we could have done to prevent this, unfortunately. |
b661730
to
9c1c87f
Compare
9c1c87f
to
2bd3405
Compare
🤖 Beep boop. I am GabrieleBOT. 🤖
I received an update so that I can inform you directly of the changes (but feel free to check the release notes).
The most recent version of climacommon uses the newly released Julia 1.11.2.